diff --git a/app/src/main/java/eu/faircode/email/Core.java b/app/src/main/java/eu/faircode/email/Core.java index a5be1adb11..398a66d01e 100644 --- a/app/src/main/java/eu/faircode/email/Core.java +++ b/app/src/main/java/eu/faircode/email/Core.java @@ -3972,10 +3972,7 @@ class Core { message.tls = helper.getTLS(); message.dkim = MessageHelper.getAuthentication("dkim", authentication); if (Boolean.TRUE.equals(message.dkim)) - if (BuildConfig.DEBUG && dkim_verify) - message.dkim = helper.verifyDKIM(context); - else - message.dkim = helper.checkDKIMRequirements(); + message.dkim = helper.checkDKIMRequirements(); message.spf = MessageHelper.getAuthentication("spf", authentication); if (message.spf == null && helper.getSPF()) message.spf = true; diff --git a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java index 6457bf4b33..33a29b6684 100644 --- a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java +++ b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java @@ -171,7 +171,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc private SwitchCompat swLogarithmicBackoff; private SwitchCompat swExactAlarms; private SwitchCompat swInfra; - private SwitchCompat swDkimVerify; private SwitchCompat swDupMsgId; private SwitchCompat swTestIab; private Button btnImportProviders; @@ -337,7 +336,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc swLogarithmicBackoff = view.findViewById(R.id.swLogarithmicBackoff); swExactAlarms = view.findViewById(R.id.swExactAlarms); swInfra = view.findViewById(R.id.swInfra); - swDkimVerify = view.findViewById(R.id.swDkimVerify); swDupMsgId = view.findViewById(R.id.swDupMsgId); swTestIab = view.findViewById(R.id.swTestIab); btnImportProviders = view.findViewById(R.id.btnImportProviders); @@ -1138,14 +1136,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc } }); - swDkimVerify.setVisibility(BuildConfig.DEBUG ? View.VISIBLE : View.GONE); - swDkimVerify.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() { - @Override - public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { - prefs.edit().putBoolean("dkim_verify", checked).apply(); - } - }); - swDupMsgId.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() { @Override public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { @@ -1737,7 +1727,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc swLogarithmicBackoff.setChecked(prefs.getBoolean("logarithmic_backoff", true)); swExactAlarms.setChecked(prefs.getBoolean("exact_alarms", true)); swInfra.setChecked(prefs.getBoolean("infra", false)); - swDkimVerify.setChecked(prefs.getBoolean("dkim_verify", false)); swDupMsgId.setChecked(prefs.getBoolean("dup_msgids", false)); swTestIab.setChecked(prefs.getBoolean("test_iab", false)); diff --git a/app/src/main/java/eu/faircode/email/MessageHelper.java b/app/src/main/java/eu/faircode/email/MessageHelper.java index ba603888bd..086a75ff1e 100644 --- a/app/src/main/java/eu/faircode/email/MessageHelper.java +++ b/app/src/main/java/eu/faircode/email/MessageHelper.java @@ -1868,10 +1868,6 @@ public class MessageHelper { return true; } - boolean verifyDKIM(Context context) throws MessagingException { - return true; - } - Address[] getMailFrom(String[] headers) { if (headers == null) return null; diff --git a/app/src/main/res/layout/fragment_options_misc.xml b/app/src/main/res/layout/fragment_options_misc.xml index 3864646856..c8ab8b92ac 100644 --- a/app/src/main/res/layout/fragment_options_misc.xml +++ b/app/src/main/res/layout/fragment_options_misc.xml @@ -1356,17 +1356,6 @@ app:srcCompat="@drawable/infra_zoho" tools:ignore="MissingConstraints" /> - - + app:layout_constraintTop_toBottomOf="@id/flowInfra" /> Empty connection pool Use exact timers Show infrastructure - DKIM verification Duplicates by message ID Test IAB Import providers