From 4e7092e0f840ed844be8ed2b4ba5ec71b98663f0 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Thu, 6 Feb 2025 18:34:20 +0100
Subject: [PATCH] Revert "Attempt to fix folder item layout issue"

This reverts commit ffde5bb5f6a7d8f2cdadfce36daa52a064bdaf59.
---
 .../java/eu/faircode/email/AdapterFolder.java     | 15 +--------------
 app/src/main/res/layout/item_folder.xml           |  4 ++--
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterFolder.java b/app/src/main/java/eu/faircode/email/AdapterFolder.java
index 18d1e693a4..31016b0f26 100644
--- a/app/src/main/java/eu/faircode/email/AdapterFolder.java
+++ b/app/src/main/java/eu/faircode/email/AdapterFolder.java
@@ -52,8 +52,6 @@ import androidx.annotation.NonNull;
 import androidx.annotation.RequiresApi;
 import androidx.appcompat.app.AlertDialog;
 import androidx.appcompat.widget.PopupMenu;
-import androidx.constraintlayout.widget.ConstraintLayout;
-import androidx.constraintlayout.widget.ConstraintSet;
 import androidx.constraintlayout.widget.Group;
 import androidx.core.content.pm.ShortcutInfoCompat;
 import androidx.fragment.app.Fragment;
@@ -125,7 +123,7 @@ public class AdapterFolder extends RecyclerView.Adapter<AdapterFolder.ViewHolder
     private static final int DENSE_ITEMS_THRESHOLD_MANY = 50;
 
     public class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener, View.OnLongClickListener {
-        private ConstraintLayout view;
+        private View view;
 
         private View vwColor;
         private ImageView ivState;
@@ -461,17 +459,6 @@ public class AdapterFolder extends RecyclerView.Adapter<AdapterFolder.ViewHolder
                 if (btnHelp != null)
                     btnHelp.setVisibility(folder.error == null ? View.GONE : View.VISIBLE);
 
-                ConstraintSet constraintSet = new ConstraintSet();
-                constraintSet.clone(view);
-                if (show_flagged && !show_compact) {
-                    constraintSet.connect(R.id.ibSync, ConstraintSet.END, R.id.tvFlaggedEnd, ConstraintSet.START);
-                    constraintSet.connect(R.id.ibMessages, ConstraintSet.END, R.id.tvFlaggedEnd, ConstraintSet.START);
-                } else {
-                    constraintSet.connect(R.id.ibSync, ConstraintSet.END, view.getId(), ConstraintSet.END);
-                    constraintSet.connect(R.id.ibMessages, ConstraintSet.END, view.getId(), ConstraintSet.END);
-                }
-                constraintSet.applyTo(view);
-
                 grpFlagged.setVisibility(show_flagged && show_compact ? View.VISIBLE : View.GONE);
                 grpFlaggedEnd.setVisibility(show_flagged && !show_compact ? View.VISIBLE : View.GONE);
                 grpExtended.setVisibility(show_compact ? View.GONE : View.VISIBLE);
diff --git a/app/src/main/res/layout/item_folder.xml b/app/src/main/res/layout/item_folder.xml
index 7fe648154c..db6b157db4 100644
--- a/app/src/main/res/layout/item_folder.xml
+++ b/app/src/main/res/layout/item_folder.xml
@@ -152,12 +152,12 @@
                 android:id="@+id/ibMessages"
                 android:layout_width="24dp"
                 android:layout_height="24dp"
-                android:layout_marginEnd="6dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
                 android:contentDescription="@string/title_accessibility_unseen"
                 app:layout_constraintBottom_toBottomOf="@+id/tvName"
                 app:layout_constraintEnd_toStartOf="@+id/tvFlaggedEnd"
                 app:layout_constraintTop_toTopOf="@+id/tvName"
+                app:layout_goneMarginEnd="6dp"
                 app:srcCompat="@drawable/twotone_mail_outline_24" />
 
             <ImageButton
@@ -230,12 +230,12 @@
                 android:id="@+id/ibSync"
                 android:layout_width="24dp"
                 android:layout_height="24dp"
-                android:layout_marginEnd="6dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
                 android:contentDescription="@string/tile_synchronize"
                 app:layout_constraintBottom_toBottomOf="@id/tvType"
                 app:layout_constraintEnd_toStartOf="@+id/tvFlaggedEnd"
                 app:layout_constraintTop_toTopOf="@+id/tvType"
+                app:layout_goneMarginEnd="6dp"
                 app:srcCompat="@drawable/twotone_sync_24" />
 
             <TextView