From b2d37c3964156ba259b3d237ef91eb16af3b48c3 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Wed, 7 Jul 2021 06:55:08 +0200
Subject: [PATCH] Prevent empty/local image links

---
 app/src/main/java/eu/faircode/email/HtmlHelper.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/HtmlHelper.java b/app/src/main/java/eu/faircode/email/HtmlHelper.java
index 93d28b1d75..9994e0bcdd 100644
--- a/app/src/main/java/eu/faircode/email/HtmlHelper.java
+++ b/app/src/main/java/eu/faircode/email/HtmlHelper.java
@@ -1101,9 +1101,12 @@ public class HtmlHelper {
                         boolean linked = false;
                         Element p = img.parent();
                         while (p != null && !linked)
-                            if ("a".equals(p.tagName()))
+                            if ("a".equals(p.tagName())) {
+                                String href = p.attr("href");
+                                if (TextUtils.isEmpty(href) || href.equals("#"))
+                                    break;
                                 linked = true;
-                            else
+                            } else
                                 p = p.parent();
                         if (linked)
                             alt = context.getString(R.string.title_image_link);