From f14de224aa458f0181df6592dedf51c91b40c1a2 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Tue, 11 Dec 2018 11:31:31 +0100
Subject: [PATCH] Handle all unexpected errors

---
 .../main/java/eu/faircode/email/AdapterOperation.java  | 10 ++++++++++
 .../main/java/eu/faircode/email/FragmentMessages.java  |  7 ++++++-
 .../java/eu/faircode/email/FragmentOperations.java     |  5 +++++
 app/src/main/java/eu/faircode/email/FragmentSetup.java |  5 +++++
 app/src/main/java/eu/faircode/email/SimpleTask.java    |  8 ++------
 5 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterOperation.java b/app/src/main/java/eu/faircode/email/AdapterOperation.java
index c2c2f0090b..87fd760db9 100644
--- a/app/src/main/java/eu/faircode/email/AdapterOperation.java
+++ b/app/src/main/java/eu/faircode/email/AdapterOperation.java
@@ -123,6 +123,11 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
                                         .putExtra("folder", folder.id)
                                         .putExtra("outgoing", folder.isOutgoing()));
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(context, owner, ex);
+                    }
                 }.load(context, owner, args);
             } else {
                 Bundle args = new Bundle();
@@ -144,6 +149,11 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
                                         .putExtra("thread", message.thread)
                                         .putExtra("id", message.id));
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(context, owner, ex);
+                    }
                 }.load(context, owner, args);
             }
         }
diff --git a/app/src/main/java/eu/faircode/email/FragmentMessages.java b/app/src/main/java/eu/faircode/email/FragmentMessages.java
index a33f425254..63acfcf771 100644
--- a/app/src/main/java/eu/faircode/email/FragmentMessages.java
+++ b/app/src/main/java/eu/faircode/email/FragmentMessages.java
@@ -243,6 +243,11 @@ public class FragmentMessages extends FragmentEx {
                             Snackbar.make(view, R.string.title_sync_queued, Snackbar.LENGTH_LONG).show();
                         }
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(getContext(), getViewLifecycleOwner(), ex);
+                    }
                 }.load(FragmentMessages.this, args);
             }
         });
@@ -1813,7 +1818,7 @@ public class FragmentMessages extends FragmentEx {
 
                     @Override
                     protected void onException(Bundle args, Throwable ex) {
-                        super.onException(args, ex);
+                        Helper.unexpectedError(getContext(), getViewLifecycleOwner(), ex);
                     }
                 }.load(FragmentMessages.this, args);
             }
diff --git a/app/src/main/java/eu/faircode/email/FragmentOperations.java b/app/src/main/java/eu/faircode/email/FragmentOperations.java
index d0b213b029..c29d79e881 100644
--- a/app/src/main/java/eu/faircode/email/FragmentOperations.java
+++ b/app/src/main/java/eu/faircode/email/FragmentOperations.java
@@ -148,6 +148,11 @@ public class FragmentOperations extends FragmentEx {
                                 }
                                 return null;
                             }
+
+                            @Override
+                            protected void onException(Bundle args, Throwable ex) {
+                                Helper.unexpectedError(getContext(), getViewLifecycleOwner(), ex);
+                            }
                         }.load(FragmentOperations.this, new Bundle());
                     }
                 })
diff --git a/app/src/main/java/eu/faircode/email/FragmentSetup.java b/app/src/main/java/eu/faircode/email/FragmentSetup.java
index 5f16816cc2..d33cd8a5de 100644
--- a/app/src/main/java/eu/faircode/email/FragmentSetup.java
+++ b/app/src/main/java/eu/faircode/email/FragmentSetup.java
@@ -454,6 +454,11 @@ public class FragmentSetup extends FragmentEx {
                         EntityOperation.sync(db, folder.id);
                     return null;
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(getContext(), getViewLifecycleOwner(), ex);
+                }
             }.load(FragmentSetup.this, new Bundle());
     }
 
diff --git a/app/src/main/java/eu/faircode/email/SimpleTask.java b/app/src/main/java/eu/faircode/email/SimpleTask.java
index 57f276e7a0..dce0d4cafb 100644
--- a/app/src/main/java/eu/faircode/email/SimpleTask.java
+++ b/app/src/main/java/eu/faircode/email/SimpleTask.java
@@ -162,16 +162,12 @@ public abstract class SimpleTask<T> implements LifecycleObserver {
         }
     }
 
-    protected T onLoad(Context context, Bundle args) throws Throwable {
-        // Be careful not to access members in outer scopes
-        return null;
-    }
+    protected abstract T onLoad(Context context, Bundle args) throws Throwable;
 
     protected void onLoaded(Bundle args, T data) {
     }
 
-    protected void onException(Bundle args, Throwable ex) {
-    }
+    protected abstract void onException(Bundle args, Throwable ex);
 
     private static class Result {
         Throwable ex;