Klaus Post 7ff4164d65 Fix races in IAM cache lazy loading (#19346) ...

Fix races in IAM cache

Fixes #19344

On the top level we only grab a read lock, but we write to the cache if we manage to fetch it.

a03dac41eb/cmd/iam-store.go (L446) is also flipped to what it should be AFAICT.

Change the internal cache structure to a concurrency safe implementation.

Bonus: Also switch grid implementation.

2024-03-26 11:12:57 -07:00

..

testdata

…

acl-handlers.go

…

admin-bucket-handlers.go

…

admin-handler-utils.go

…

admin-handlers_test.go

…

admin-handlers-config-kv.go

…

admin-handlers-idp-config.go

…

admin-handlers-idp-ldap.go

…

admin-handlers-pools.go

…

admin-handlers-site-replication.go

…

admin-handlers-users_test.go

…

admin-handlers-users-race_test.go

…

admin-handlers-users.go

Fix races in IAM cache lazy loading (#19346)

2024-03-26 11:12:57 -07:00

admin-handlers.go

…

admin-heal-ops.go

…

admin-router.go

…

admin-server-info.go

…

api-datatypes.go

…

api-errors_test.go

…

api-errors.go

…

api-headers_test.go

…

api-headers.go

…

api-resources_test.go

…

api-resources.go

…

api-response_test.go

…

api-response.go

…

api-router.go

…

api-utils_test.go

…

api-utils.go

…

apierrorcode_string.go

…

auth-handler_test.go

…

auth-handler.go

…

authtype_string.go

…

background-heal-ops.go

…

background-newdisks-heal-ops_gen_test.go

…

background-newdisks-heal-ops_gen.go

…

background-newdisks-heal-ops.go

…

batch-expire_gen_test.go

…

batch-expire_gen.go

…

batch-expire_test.go

…

batch-expire.go

…

batch-handlers_gen_test.go

…

batch-handlers_gen.go

…

batch-handlers.go

…

batch-job-common-types_gen_test.go

…

batch-job-common-types_gen.go

…

batch-job-common-types_test.go

…

batch-job-common-types.go

…

batch-replicate_gen_test.go

…

batch-replicate_gen.go

…

batch-replicate.go

…

batch-rotate_gen_test.go

…

batch-rotate_gen.go

…

batch-rotate.go

…

batchjobmetric_string.go

…

benchmark-utils_test.go

…

bitrot_test.go

…

bitrot-streaming.go

…

bitrot-whole.go

…

bitrot.go

…

bootstrap-messages.go

…

bootstrap-peer-server_gen_test.go

…

bootstrap-peer-server_gen.go

…

bootstrap-peer-server.go

…

bucket-encryption_test.go

…

bucket-encryption-handlers.go

…

bucket-encryption.go

…

bucket-handlers_test.go

…

bucket-handlers.go

…

bucket-lifecycle_test.go

…

bucket-lifecycle-audit.go

…

bucket-lifecycle-handlers_test.go

…

bucket-lifecycle-handlers.go

…

bucket-lifecycle.go

…

bucket-listobjects-handlers.go

…

bucket-metadata_gen_test.go

…

bucket-metadata_gen.go

…

bucket-metadata-sys.go

…

bucket-metadata.go

…

bucket-notification-handlers.go

…

bucket-object-lock.go

…

bucket-policy-handlers_test.go

…

bucket-policy-handlers.go

…

bucket-policy.go

…

bucket-quota.go

…

bucket-replication_test.go

…

bucket-replication-handlers.go

…

bucket-replication-metrics_gen_test.go

…

bucket-replication-metrics_gen.go

…

bucket-replication-metrics.go

…

bucket-replication-stats.go

…

bucket-replication-utils_gen_test.go

…

bucket-replication-utils_gen.go

…

bucket-replication-utils_test.go

…

bucket-replication-utils.go

…

bucket-replication.go

…

bucket-stats_gen_test.go

…

bucket-stats_gen.go

…

bucket-stats.go

…

bucket-targets.go

…

bucket-versioning-handler.go

…

bucket-versioning.go

…

build-constants.go

…

callhome.go

…

common-main_test.go

…

common-main.go

…

config-common.go

…

config-current_test.go

…

config-current.go

…

config-dir.go

…

config-encrypted_test.go

…

config-migrate.go

…

config-versions.go

…

config.go

…

consolelogger.go

…

copy-part-range_test.go

…

copy-part-range.go

…

crossdomain-xml-handler_test.go

…

crossdomain-xml-handler.go

…

data-scanner_test.go

…

data-scanner-metric.go

…

data-scanner.go

…

data-usage_test.go

…

data-usage-cache_gen_test.go

…

data-usage-cache_gen.go

…

data-usage-cache_test.go

…

data-usage-cache.go

…

data-usage-utils.go

…

data-usage.go

…

decommetric_string.go

…

dummy-data-generator_test.go

…

dummy-handlers.go

…

dynamic-timeouts_test.go

…

dynamic-timeouts.go

…

encryption-v1_test.go

…

encryption-v1.go

…

endpoint_contrib_test.go

…

endpoint_test.go

…

endpoint-ellipses_test.go

…

endpoint-ellipses.go

…

endpoint.go

…

erasure_test.go

…

erasure-coding.go

…

erasure-common.go

…

erasure-decode_test.go

…

erasure-decode.go

…

erasure-encode_test.go

…

erasure-encode.go

…

erasure-errors.go

…

erasure-heal_test.go

…

erasure-healing_test.go

…

erasure-healing-common_test.go

…

erasure-healing-common.go

…

erasure-healing.go

…

erasure-metadata_test.go

…

erasure-metadata-utils_test.go

…

erasure-metadata-utils.go

…

erasure-metadata.go

…

erasure-multipart.go

…

erasure-object_test.go

…

erasure-object.go

…

erasure-server-pool-decom_gen_test.go

…

erasure-server-pool-decom_gen.go

…

erasure-server-pool-decom_test.go

…

erasure-server-pool-decom.go

…

erasure-server-pool-rebalance_gen_test.go

…

erasure-server-pool-rebalance_gen.go

…

erasure-server-pool-rebalance.go

…

erasure-server-pool.go

…

erasure-sets_test.go

…

erasure-sets.go

…

erasure-utils.go

…

erasure.go

…

etcd.go

…

event-notification.go

…

format_string.go

…

format-erasure_test.go

…

format-erasure.go

…

format-meta.go

…

ftp-server-driver.go

…

ftp-server.go

…

generic-handlers_contrib.go

…

generic-handlers_test.go

…

generic-handlers.go

…

global-heal.go

…

globals.go

…

grid.go

…

handler-api.go

…

handler-utils_test.go

…

handler-utils.go

…

hasher.go

…

healingmetric_string.go

…

healthcheck-handler.go

…

healthcheck-router.go

…

http-stats.go

…

http-tracer_test.go

…

http-tracer.go

…

httprange_test.go

…

httprange.go

…

iam-etcd-store_test.go

…

iam-etcd-store.go

Fix races in IAM cache lazy loading (#19346)

2024-03-26 11:12:57 -07:00

iam-object-store.go

Fix races in IAM cache lazy loading (#19346)

2024-03-26 11:12:57 -07:00

iam-store.go

Fix races in IAM cache lazy loading (#19346)

2024-03-26 11:12:57 -07:00

iam.go

…

ilm-config.go

…

is-dir-empty_linux.go

…

is-dir-empty_other.go

…

jwt_test.go

…

jwt.go

…

kms-handlers.go

…

kms-router.go

…

last-minute_gen_test.go

…

last-minute_gen.go

…

last-minute.go

…

lceventsrc_string.go

…

leak-detect_test.go

…

license-update.go

…

listen-notification-handlers.go

…

local-locker_gen_test.go

…

local-locker_gen.go

…

local-locker_test.go

…

local-locker.go

…

lock-rest-client_test.go

…

lock-rest-client.go

…

lock-rest-server-common_test.go

…

lock-rest-server-common.go

…

lock-rest-server.go

…

main.go

…

metacache_gen_test.go

…

metacache_gen.go

…

metacache_test.go

…

metacache-bucket_test.go

…

metacache-bucket.go

…

metacache-entries_test.go

…

metacache-entries.go

…

metacache-manager.go

…

metacache-marker.go

…

metacache-server-pool.go

…

metacache-set_gen_test.go

…

metacache-set_gen.go

…

metacache-set.go

…

metacache-stream_test.go

…

metacache-stream.go

…

metacache-walk_gen_test.go

…

metacache-walk_gen.go

…

metacache-walk.go

…

metacache.go

…

metrics-realtime.go

…

metrics-resource.go

…

metrics-router.go

…

metrics-v2_gen_test.go

…

metrics-v2_gen.go

…

metrics-v2_test.go

…

metrics-v2.go

…

metrics-v3-api.go

…

metrics-v3-cache.go

…

metrics-v3-cluster-erasure-set.go

…

metrics-v3-cluster-health.go

…

metrics-v3-cluster-usage.go

…

metrics-v3-handler.go

…

metrics-v3-system-drive.go

…

metrics-v3-system-network.go

…

metrics-v3-types.go

…

metrics-v3.go

…

metrics.go

…

mrf.go

…

namespace-lock_test.go

…

namespace-lock.go

…

naughty-disk_test.go

…

net_test.go

…

net.go

…

notification-summary.go

…

notification.go

…

object_api_suite_test.go

…

object-api-common.go

…

object-api-datatypes_gen.go

…

object-api-datatypes.go

…

object-api-deleteobject_test.go

…

object-api-errors.go

…

object-api-getobjectinfo_test.go

…

object-api-input-checks.go

…

object-api-interface_gen.go

…

object-api-interface.go

…

object-api-listobjects_test.go

…

object-api-multipart_test.go

…

object-api-options.go

…

object-api-putobject_test.go

…

object-api-utils_test.go

…

object-api-utils.go

…

object-handlers_test.go

…

object-handlers-common_test.go

…

object-handlers-common.go

…

object-handlers.go

…

object-lambda-handlers.go

…

object-multipart-handlers.go

…

os_other.go

…

os_unix.go

…

os_windows.go

…

os-dirent_fileino.go

…

os-dirent_ino.go

…

os-dirent_namelen_bsd.go

…

os-dirent_namelen_linux.go

…

os-instrumented.go

…

os-readdir_test.go

…

os-readdir-common.go

…

os-reliable_test.go

…

os-reliable.go

…

os-rename_linux.go

…

os-rename_nolinux.go

…

osmetric_string.go

…

peer-rest-client.go

…

peer-rest-common.go

…

peer-rest-server.go

…

peer-s3-client.go

…

peer-s3-server.go

…

perf-tests.go

…

policy_test.go

…

post-policy_test.go

…

post-policy-fan-out.go

…

postpolicyform_test.go

…

postpolicyform.go

…

prepare-storage.go

…

rebalance-admin.go

…

rebalancemetric_string.go

…

rebalstatus_string.go

…

routers.go

…

s3-zip-handlers.go

…

scannermetric_string.go

…

server_test.go

…

server-main_test.go

…

server-main.go

…

server-rlimit.go

…

server-startup-msg_test.go

…

server-startup-msg.go

…

service.go

…

setup-type.go

…

sftp-server-driver.go

…

sftp-server.go

…

shared-lock.go

…

signals.go

…

signature-v2_test.go

…

signature-v2.go

…

signature-v4_test.go

…

signature-v4-parser_test.go

…

signature-v4-parser.go

…

signature-v4-utils_test.go

…

signature-v4-utils.go

…

signature-v4.go

…

site-replication_test.go

…

site-replication-metrics_gen_test.go

…

site-replication-metrics_gen.go

…

site-replication-metrics.go

…

site-replication-utils_gen_test.go

…

site-replication-utils_gen.go

…

site-replication-utils.go

…

site-replication.go

Fix races in IAM cache lazy loading (#19346)

2024-03-26 11:12:57 -07:00

speedtest.go

…

storage-datatypes_gen_test.go

…

storage-datatypes_gen.go

…

storage-datatypes_test.go

…

storage-datatypes.go

…

storage-errors.go

…

storage-interface.go

…

storage-rest_test.go

…

storage-rest-client.go

…

storage-rest-common_gen_test.go

…

storage-rest-common_gen.go

…

storage-rest-common.go

…

storage-rest-server.go

…

storagemetric_string.go

…

streaming-signature-v4_test.go

…

streaming-signature-v4.go

…

streaming-v4-unsigned.go

…

sts-datatypes.go

…

sts-errors.go

…

sts-handlers_test.go

…

sts-handlers.go

…

stserrorcode_string.go

…

test-utils_test.go

…

tier_gen_test.go

…

tier_gen.go

…

tier_test.go

…

tier-handlers.go

…

tier-last-day-stats_gen_test.go

…

tier-last-day-stats_gen.go

…

tier-last-day-stats.go

…

tier-sweeper.go

…

tier.go

…

typed-errors.go

…

untar.go

…

update_fips.go

…

update_nofips.go

…

update_test.go

…

update-notifier_test.go

…

update-notifier.go

…

update.go

…

url_test.go

…

utils_test.go

…

utils.go

…

veeam-sos-api.go

…

version_test.go

…

warm-backend-azure.go

…

warm-backend-gcs.go

…

warm-backend-minio.go

…

warm-backend-s3.go

…

warm-backend.go

…

xl-storage_noatime_notsupported.go

…

xl-storage_noatime_supported.go

…

xl-storage_test.go

…

xl-storage_unix_test.go

…

xl-storage_windows_test.go

…

xl-storage-disk-id-check.go

…

xl-storage-errors_test.go

…

xl-storage-errors.go

…

xl-storage-format_test.go

…

xl-storage-format-utils_test.go

…

xl-storage-format-utils.go

…

xl-storage-format-v1_gen_test.go

…

xl-storage-format-v1_gen.go

…

xl-storage-format-v1.go

…

xl-storage-format-v2_gen_test.go

…

xl-storage-format-v2_gen.go

…

xl-storage-format-v2_string.go

…

xl-storage-format-v2_test.go

…

xl-storage-format-v2-legacy.go

…

xl-storage-format-v2.go

…

xl-storage-free-version_test.go

…

xl-storage-free-version.go

…

xl-storage-meta-inline.go

…

xl-storage.go

…