Mirrors/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-28 12:36:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: separate commit formatting from changed gate

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-23 23:55:36 +01:00
parent d8eb5ffef0
commit e28fca2e11
7 changed files with 27 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test/git-hooks-pre-commit.test.ts
View File

@@ -64,11 +64,6 @@ describe("git-hooks/pre-commit (integration)", () => {
// Use the real hook script and lightweight helper stubs.
const fakeBinDir = installPreCommitFixture(dir);
// The hook can end with `pnpm check:changed --staged`, but this fixture is only
// exercising staged-file handling.
// Stub pnpm too so Windows CI does not invoke a real package-manager command in the temp repo.
writeExecutable(fakeBinDir, "pnpm", "#!/usr/bin/env bash\nexit 0\n");
// Create an untracked file that should NOT be staged by the hook.
writeFileSync(path.join(dir, "secret.txt"), "do-not-stage\n", "utf8");
@@ -85,8 +80,8 @@ describe("git-hooks/pre-commit (integration)", () => {
expect(staged).toEqual(["--all"]);
});
it("runs changed-scope check for non-doc staged changes", () => {
const dir = makeTempRepoRoot(tempDirs, "openclaw-pre-commit-check-changed-");
it("does not run the changed-scope check for non-doc staged changes", () => {
const dir = makeTempRepoRoot(tempDirs, "openclaw-pre-commit-no-check-changed-");
run(dir, "git", ["init", "-q", "--initial-branch=main"]);
const fakeBinDir = installPreCommitFixture(dir);
@@ -95,7 +90,7 @@ describe("git-hooks/pre-commit (integration)", () => {
writeExecutable(
fakeBinDir,
"pnpm",
"#!/usr/bin/env bash\nprintf '%s\\n' \"$*\" > pnpm-args.txt\n",
"#!/usr/bin/env bash\necho 'pnpm should not run from pre-commit' >&2\nexit 99\n",
);
writeFileSync(path.join(dir, "tracked.txt"), "hello\n", "utf8");
@@ -105,11 +100,11 @@ describe("git-hooks/pre-commit (integration)", () => {
PATH: `${fakeBinDir}:${process.env.PATH ?? ""}`,
});
expect(run(dir, "cat", ["pnpm-args.txt"])).toBe("check:changed --staged");
expect(run(dir, "git", ["diff", "--cached", "--name-only"])).toBe("tracked.txt");
});
it("skips changed-scope check when FAST_COMMIT is enabled", () => {
const dir = makeTempRepoRoot(tempDirs, "openclaw-pre-commit-yolo-");
it("ignores FAST_COMMIT because the hook is already formatting-only", () => {
const dir = makeTempRepoRoot(tempDirs, "openclaw-pre-commit-fast-");
run(dir, "git", ["init", "-q", "--initial-branch=main"]);
const fakeBinDir = installPreCommitFixture(dir);
@@ -125,13 +120,11 @@ describe("git-hooks/pre-commit (integration)", () => {
writeFileSync(path.join(dir, "tracked.txt"), "hello\n", "utf8");
run(dir, "git", ["add", "--", "tracked.txt"]);
const output = run(dir, "bash", ["git-hooks/pre-commit"], {
run(dir, "bash", ["git-hooks/pre-commit"], {
PATH: `${fakeBinDir}:${process.env.PATH ?? ""}`,
FAST_COMMIT: "1",
});
expect(output).toContain(
"FAST_COMMIT enabled: skipping changed-scope check in pre-commit hook.",
);
expect(run(dir, "git", ["diff", "--cached", "--name-only"])).toBe("tracked.txt");
});
});