mirror of
https://github.com/openclaw/openclaw.git
synced 2026-04-28 12:36:55 +02:00
277 lines
7.9 KiB
TypeScript
277 lines
7.9 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
||
import {
|
||
candidateLabels,
|
||
classifyPullRequestCandidateLabels,
|
||
managedLabelSpecs,
|
||
runBarnacleAutoResponse,
|
||
} from "../../scripts/github/barnacle-auto-response.mjs";
|
||
|
||
const blankTemplateBody = [
|
||
"## Summary",
|
||
"",
|
||
"Describe the problem and fix in 2–5 bullets:",
|
||
"",
|
||
"- Problem:",
|
||
"- Why it matters:",
|
||
"- What changed:",
|
||
"- What did NOT change (scope boundary):",
|
||
"",
|
||
"## Linked Issue/PR",
|
||
"",
|
||
"- Closes #",
|
||
"- Related #",
|
||
"",
|
||
"## Root Cause (if applicable)",
|
||
"",
|
||
"- Root cause:",
|
||
"",
|
||
"## Regression Test Plan (if applicable)",
|
||
"",
|
||
"- Target test or file:",
|
||
].join("\n");
|
||
|
||
function pr(title: string, body = blankTemplateBody) {
|
||
return {
|
||
title,
|
||
body,
|
||
};
|
||
}
|
||
|
||
function file(filename: string, status = "modified") {
|
||
return {
|
||
filename,
|
||
status,
|
||
};
|
||
}
|
||
|
||
function barnacleContext(pullRequest: Record<string, unknown>, labels: string[] = []) {
|
||
return {
|
||
repo: {
|
||
owner: "openclaw",
|
||
repo: "openclaw",
|
||
},
|
||
payload: {
|
||
action: "opened",
|
||
pull_request: {
|
||
number: 123,
|
||
title: "Cleanup plugin docs",
|
||
body: blankTemplateBody,
|
||
author_association: "CONTRIBUTOR",
|
||
user: {
|
||
login: "contributor",
|
||
},
|
||
labels: labels.map((name) => ({ name })),
|
||
...pullRequest,
|
||
},
|
||
},
|
||
};
|
||
}
|
||
|
||
function barnacleGithub(files: ReturnType<typeof file>[]) {
|
||
const calls = {
|
||
addLabels: [] as Array<{ issue_number: number; labels: string[] }>,
|
||
removeLabel: [] as Array<{ issue_number: number; name: string }>,
|
||
};
|
||
const github = {
|
||
paginate: async () => files,
|
||
rest: {
|
||
issues: {
|
||
addLabels: async (params: { issue_number: number; labels: string[] }) => {
|
||
calls.addLabels.push(params);
|
||
},
|
||
createComment: async () => undefined,
|
||
createLabel: async () => undefined,
|
||
getLabel: async (params: { name: string }) => ({
|
||
data: {
|
||
color:
|
||
managedLabelSpecs[params.name as keyof typeof managedLabelSpecs]?.color ?? "C5DEF5",
|
||
description:
|
||
managedLabelSpecs[params.name as keyof typeof managedLabelSpecs]?.description ?? "",
|
||
},
|
||
}),
|
||
lock: async () => undefined,
|
||
removeLabel: async (params: { issue_number: number; name: string }) => {
|
||
calls.removeLabel.push(params);
|
||
},
|
||
update: async () => undefined,
|
||
updateLabel: async () => undefined,
|
||
},
|
||
pulls: {
|
||
listFiles: async () => files,
|
||
},
|
||
repos: {
|
||
getCollaboratorPermissionLevel: async () => ({
|
||
data: {
|
||
role_name: "read",
|
||
},
|
||
}),
|
||
},
|
||
teams: {
|
||
getMembershipForUserInOrg: async () => {
|
||
const error = new Error("not found") as Error & { status: number };
|
||
error.status = 404;
|
||
throw error;
|
||
},
|
||
},
|
||
},
|
||
};
|
||
return { calls, github };
|
||
}
|
||
|
||
describe("barnacle-auto-response", () => {
|
||
it("keeps Barnacle-owned labels documented and ClawHub spelled correctly", () => {
|
||
expect(managedLabelSpecs["r: skill"].description).toContain("ClawHub");
|
||
expect(managedLabelSpecs["r: skill"].description).not.toContain("Clawdhub");
|
||
expect(managedLabelSpecs.dirty.description).toContain("dirty/unrelated");
|
||
expect(managedLabelSpecs["r: support"].description).toContain("support requests");
|
||
expect(managedLabelSpecs["r: third-party-extension"].description).toContain("ClawHub");
|
||
expect(managedLabelSpecs["r: too-many-prs"].description).toContain("ten active PRs");
|
||
|
||
for (const label of Object.values(candidateLabels)) {
|
||
expect(managedLabelSpecs[label]).toBeDefined();
|
||
expect(managedLabelSpecs[label].description).toMatch(/^Candidate:/);
|
||
}
|
||
});
|
||
|
||
it("labels docs-only discoverability churn without closing it", () => {
|
||
const labels = classifyPullRequestCandidateLabels(pr("Update README translation"), [
|
||
file("README.md"),
|
||
]);
|
||
|
||
expect(labels).toEqual(
|
||
expect.arrayContaining([
|
||
candidateLabels.blankTemplate,
|
||
candidateLabels.lowSignalDocs,
|
||
candidateLabels.docsDiscoverability,
|
||
]),
|
||
);
|
||
});
|
||
|
||
it("does not treat template boilerplate as behavior evidence for test-only churn", () => {
|
||
const labels = classifyPullRequestCandidateLabels(pr("Add test coverage"), [
|
||
file("src/gateway/foo.test.ts"),
|
||
]);
|
||
|
||
expect(labels).toEqual(
|
||
expect.arrayContaining([candidateLabels.blankTemplate, candidateLabels.testOnlyNoBug]),
|
||
);
|
||
});
|
||
|
||
it("uses linked issues as context and suppresses low-signal docs labels", () => {
|
||
const labels = classifyPullRequestCandidateLabels(
|
||
pr("Update docs", `${blankTemplateBody}\n\nRelated #12345`),
|
||
[file("docs/plugins/community.md")],
|
||
);
|
||
|
||
expect(labels).not.toContain(candidateLabels.lowSignalDocs);
|
||
expect(labels).not.toContain(candidateLabels.docsDiscoverability);
|
||
});
|
||
|
||
it("warns on broad high-surface PRs instead of auto-closing them as dirty", () => {
|
||
const labels = classifyPullRequestCandidateLabels(pr("Cleanup plugin docs"), [
|
||
file("ui/src/app.ts"),
|
||
file("src/gateway/server.ts"),
|
||
file("extensions/slack/src/index.ts"),
|
||
file("docs/plugins/community.md"),
|
||
]);
|
||
|
||
expect(labels).toContain(candidateLabels.dirtyCandidate);
|
||
});
|
||
|
||
it("suppresses dirty-candidate when the PR has concrete behavior context", () => {
|
||
const body = [
|
||
"- Problem: gateway crashes when plugin metadata is missing",
|
||
"- Why it matters: users lose the running session",
|
||
"- What changed: add a guard around metadata loading",
|
||
].join("\n");
|
||
|
||
const labels = classifyPullRequestCandidateLabels(pr("Fix gateway crash", body), [
|
||
file("ui/src/app.ts"),
|
||
file("src/gateway/server.ts"),
|
||
file("extensions/slack/src/index.ts"),
|
||
file("docs/plugins/community.md"),
|
||
]);
|
||
|
||
expect(labels).not.toContain(candidateLabels.dirtyCandidate);
|
||
});
|
||
|
||
it("does not add candidate labels to maintainer-authored PRs", async () => {
|
||
const { calls, github } = barnacleGithub([
|
||
file("ui/src/app.ts"),
|
||
file("src/gateway/server.ts"),
|
||
file("extensions/slack/src/index.ts"),
|
||
file("docs/plugins/community.md"),
|
||
]);
|
||
|
||
await runBarnacleAutoResponse({
|
||
github,
|
||
context: barnacleContext({
|
||
author_association: "OWNER",
|
||
user: {
|
||
login: "maintainer",
|
||
},
|
||
}),
|
||
core: {
|
||
info: () => undefined,
|
||
},
|
||
});
|
||
|
||
expect(calls.addLabels).toEqual([]);
|
||
});
|
||
|
||
it("removes stale Barnacle candidate and PR-limit labels from maintainer-authored PRs", async () => {
|
||
const { calls, github } = barnacleGithub([
|
||
file("ui/src/app.ts"),
|
||
file("src/gateway/server.ts"),
|
||
file("extensions/slack/src/index.ts"),
|
||
file("docs/plugins/community.md"),
|
||
]);
|
||
|
||
await runBarnacleAutoResponse({
|
||
github,
|
||
context: barnacleContext(
|
||
{
|
||
author_association: "OWNER",
|
||
user: {
|
||
login: "maintainer",
|
||
},
|
||
},
|
||
[candidateLabels.dirtyCandidate, "r: too-many-prs"],
|
||
),
|
||
core: {
|
||
info: () => undefined,
|
||
},
|
||
});
|
||
|
||
expect(calls.removeLabel).toEqual(
|
||
expect.arrayContaining([
|
||
expect.objectContaining({ name: candidateLabels.dirtyCandidate }),
|
||
expect.objectContaining({ name: "r: too-many-prs" }),
|
||
]),
|
||
);
|
||
});
|
||
|
||
it("still adds candidate labels to broad contributor PRs", async () => {
|
||
const { calls, github } = barnacleGithub([
|
||
file("ui/src/app.ts"),
|
||
file("src/gateway/server.ts"),
|
||
file("extensions/slack/src/index.ts"),
|
||
file("docs/plugins/community.md"),
|
||
]);
|
||
|
||
await runBarnacleAutoResponse({
|
||
github,
|
||
context: barnacleContext({}),
|
||
core: {
|
||
info: () => undefined,
|
||
},
|
||
});
|
||
|
||
expect(calls.addLabels).toContainEqual(
|
||
expect.objectContaining({
|
||
labels: expect.arrayContaining([candidateLabels.dirtyCandidate]),
|
||
}),
|
||
);
|
||
});
|
||
});
|