mirror of
https://github.com/openclaw/openclaw.git
synced 2026-04-28 20:46:57 +02:00
b64bfc5d9a
* fix(github-copilot): preserve all reasoning IDs and add gpt-5.3-codex support
The existing guard (8fd15ed0e5) only skipped rewriting reasoning item IDs
when encrypted_content was a non-null string. When gpt-5.3-codex is used
via GitHub Copilot, the model falls through to the forward-compat catch-all
with reasoning:false, so encrypted_content is never requested and arrives
as null — bypassing the guard and causing a rewrite. Copilot validates
reasoning item IDs server-side regardless of whether the client includes
encrypted_content, so the rewritten id triggers the 400 error.
Two changes:
1. connection-bound-ids.ts: skip ALL reasoning items unconditionally.
Reasoning items always reference server-side state bound to their
original ID; rewriting any of them breaks Copilot's lookup.
2. models.ts + index.ts: extend the forward-compat cloning logic to
cover gpt-5.3-codex (adds it to the template-target set and to
CODEX_TEMPLATE_MODEL_IDS so it can also serve as a template source
for gpt-5.4). Adds gpt-5.3-codex to COPILOT_XHIGH_MODEL_IDS for
the thinking profile.
Thanks @InvalidPandaa.
* docs(github-copilot): clarify gpt-5.3-codex is a no-op template for itself
https://claude.ai/code/session_01EAFmq4WyKkiUkVAqRXp4Bm
* fix(github-copilot): remove dead reasoning prefix branch in deriveReplacementId
https://claude.ai/code/session_01EAFmq4WyKkiUkVAqRXp4Bm
* fix(github-copilot): align reasoning id replay tests
* test(plugin-sdk): use cjs sidecar for require fast path
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
import type {
|
|
ProviderResolveDynamicModelContext,
|
|
ProviderRuntimeModel,
|
|
} from "openclaw/plugin-sdk/core";
|
|
import { normalizeModelCompat } from "openclaw/plugin-sdk/provider-model-shared";
|
|
import { normalizeOptionalLowercaseString } from "openclaw/plugin-sdk/text-runtime";
|
|
|
|
export const PROVIDER_ID = "github-copilot";
|
|
const CODEX_FORWARD_COMPAT_TARGET_IDS = new Set(["gpt-5.4", "gpt-5.3-codex"]);
|
|
// gpt-5.3-codex is only a useful template when gpt-5.4 is the target; it is
|
|
// always a registry miss (and therefore skipped) when it is the target itself.
|
|
const CODEX_TEMPLATE_MODEL_IDS = ["gpt-5.3-codex", "gpt-5.2-codex"] as const;
|
|
|
|
const DEFAULT_CONTEXT_WINDOW = 128_000;
|
|
const DEFAULT_MAX_TOKENS = 8192;
|
|
|
|
function isCopilotCodexModelId(modelId: string): boolean {
|
|
return /(?:^|[-_.])codex(?:$|[-_.])/.test(modelId);
|
|
}
|
|
|
|
export function resolveCopilotTransportApi(
|
|
modelId: string,
|
|
): "anthropic-messages" | "openai-responses" {
|
|
return (normalizeOptionalLowercaseString(modelId) ?? "").includes("claude")
|
|
? "anthropic-messages"
|
|
: "openai-responses";
|
|
}
|
|
|
|
export function resolveCopilotForwardCompatModel(
|
|
ctx: ProviderResolveDynamicModelContext,
|
|
): ProviderRuntimeModel | undefined {
|
|
const trimmedModelId = ctx.modelId.trim();
|
|
if (!trimmedModelId) {
|
|
return undefined;
|
|
}
|
|
|
|
// If the model is already in the registry, let the normal path handle it.
|
|
const lowerModelId = normalizeOptionalLowercaseString(trimmedModelId) ?? "";
|
|
const existing = ctx.modelRegistry.find(PROVIDER_ID, lowerModelId);
|
|
if (existing) {
|
|
return undefined;
|
|
}
|
|
|
|
// For gpt-5.4 and gpt-5.3-codex, clone from a registered codex template
|
|
// to inherit the correct reasoning and capability flags.
|
|
if (CODEX_FORWARD_COMPAT_TARGET_IDS.has(lowerModelId)) {
|
|
for (const templateId of CODEX_TEMPLATE_MODEL_IDS) {
|
|
const template = ctx.modelRegistry.find(
|
|
PROVIDER_ID,
|
|
templateId,
|
|
) as ProviderRuntimeModel | null;
|
|
if (!template) {
|
|
continue;
|
|
}
|
|
return normalizeModelCompat({
|
|
...template,
|
|
id: trimmedModelId,
|
|
name: trimmedModelId,
|
|
} as ProviderRuntimeModel);
|
|
}
|
|
// Template not found — fall through to synthetic catch-all below.
|
|
}
|
|
|
|
// Catch-all: create a synthetic model definition for any unknown model ID.
|
|
// The Copilot API is OpenAI-compatible and will return its own error if the
|
|
// model isn't available on the user's plan. This lets new models be used
|
|
// by simply adding them to agents.defaults.models in openclaw.json — no
|
|
// code change required.
|
|
const reasoning = /^o[13](\b|$)/.test(lowerModelId) || isCopilotCodexModelId(lowerModelId);
|
|
return normalizeModelCompat({
|
|
id: trimmedModelId,
|
|
name: trimmedModelId,
|
|
provider: PROVIDER_ID,
|
|
api: resolveCopilotTransportApi(trimmedModelId),
|
|
reasoning,
|
|
// Optimistic: most Copilot models support images, and the API rejects
|
|
// image payloads for text-only models rather than failing silently.
|
|
input: ["text", "image"],
|
|
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
|
|
contextWindow: DEFAULT_CONTEXT_WINDOW,
|
|
maxTokens: DEFAULT_MAX_TOKENS,
|
|
} as ProviderRuntimeModel);
|
|
}
|